[bisq-network/bisq-core] Fix typos (#109)

Chris Beams notifications at github.com
Tue May 8 09:53:25 UTC 2018


cbeams requested changes on this pull request.

NACK. Many changes look good, but a few things need to be addressed. See individual review comments. Thanks, @rex4539.

> @@ -1501,7 +1501,7 @@ systemTray.tooltip=Bisq: The decentralized exchange network
 ####################################################################
 
 guiUtil.miningFeeInfo=Please be sure that the mining fee used at your external wallet is \
-at least {0} Satoshi/Byte. Otherwise the trade transactions cannot be confirmed and a trade would end up in a dispute.
+at least {0} Satoshis/byte. Otherwise the trade transactions cannot be confirmed and a trade would end up in a dispute.

And with regard to pluralizing as "satoshis", this appears to be fine, and I agree it reads better in this context. See https://en.bitcoin.it/wiki/Satoshi_(unit)#Plural.

We may also want to type out the phrase "satoshis per byte" instead of "satoshis/byte".

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-core/pull/109#pullrequestreview-118296870
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20180508/ae835abd/attachment-0002.html>


More information about the github mailing list