[bisq-network/bisq-assets] Check bisq.asset.Asset file sorting during CI (#11)

Chris Beams notifications at github.com
Tue May 15 11:40:53 UTC 2018


@blabno, note that I updated the description of the PR as well. In general, even if you and I have just discussed something in Slack (as we had in this situation), even a one-line description in the PR is good practice. It provides context for the uninitiated, especially those who might come along and do reviews. As time goes by we want to get more and more in the culture / mode where anybody who wants to can do a review. This means that PRs should be as self-contained as they can be, without requiring context from Slack or wherever else.

No big deal—just want to start emphasizing this. Really, just a one liner is fine, whatever you think would help an uninitiated person understand why this PR is being submitted, why now, etc.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-assets/pull/11#issuecomment-389136559
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20180515/604ac447/attachment-0002.html>


More information about the github mailing list