[bisq-network/bisq-assets] Add support for CryptoTari; add Stellar token address validator (#19)

Bernard Labno notifications at github.com
Tue May 29 15:53:25 UTC 2018


blabno requested changes on this pull request.

NACK per comment.

> + * Validates whether a stellar address has the necessary trustline
+ * established to receive the token. The validator uses the stellar
+ * horizon network to do the lookup.
+ *
+ * @author Peter Molnar/litlp007
+ * @since 0.7.0
+ */
+public class StellarTokenAddressValidator implements AddressValidator {
+
+   private String code;
+   private String issuer;
+
+   public static String getText(String url) throws Exception {
+        URL website = new URL(url);
+        URLConnection connection = website.openConnection();
+        BufferedReader in = new BufferedReader(

I don't think we want to make any external queries to validate anything. 
Validation must work offline.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-assets/pull/19#pullrequestreview-124057796
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20180529/7cc59088/attachment-0002.html>


More information about the github mailing list