[bisq-network/bisq-assets] Add support for CryptoTari; add Stellar token address validator (#19)

[LiTlP007]

litlp007 commented on this pull request.



> + * Validates whether a stellar address has the necessary trustline
+ * established to receive the token. The validator uses the stellar
+ * horizon network to do the lookup.
+ *
+ * @author Peter Molnar/litlp007
+ * @since 0.7.0
+ */
+public class StellarTokenAddressValidator implements AddressValidator {
+
+   private String code;
+   private String issuer;
+
+   public static String getText(String url) throws Exception {
+        URL website = new URL(url);
+        URLConnection connection = website.openConnection();
+        BufferedReader in = new BufferedReader(

Thank you for the quick response.
I understand your position, but let me explain the situation a bit more so you may reconsider.

The ripple/stellar network works in a way that there is no way to tell offline whether a specific address can receive a specific token or not (an account needs to set up a "trust line" before it can hold a specific token).
We could validate the address syntax offline but if someone would buy the token without the established trust line then the seller would not be able to transfer the tokens even if he/she wanted to and the deal would go straight to arbitration (as the seller could not contact the buyer directly to tell him/her to establish the needed trust).

Given the above would you reconsider the rejection - or suggest an alternative?

Thanks!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-assets/pull/19#discussion_r191497777
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20180529/5a8e2c76/attachment-0002.html>