[bisq-network/bisq] Bonded reputation (#1851)

[sqrrm]

sqrrm commented on this pull request.

ACK

> @@ -646,6 +646,10 @@ public boolean isLockupOutput(TxOutput txOutput) {
                 .findFirst());
     }
 
+    public Optional<TxOutput> getLockupOpReturnTxOutput(String txId) {

Perhaps a check to make there is actually an opreturn output would be good

> @@ -88,7 +99,18 @@
     }
 
     public boolean isLockupAndUnspent() {
-        return !isSpent() && getTxType() == TxType.LOCKUP;
+        boolean isLocked;

I've tried to avoid using 'locked' as a key word, it's not entirely clear. Better to use 'lockup', 'unlocking', 'unlocked' or more specific words for clarity.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/1851#pullrequestreview-170783176
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20181101/d397b543/attachment-0001.html>