[bisq-network/bisq] Delist untraded assets (#1861)

Bernard Labno notifications at github.com
Sat Nov 3 16:19:33 UTC 2018


It should be enough to remove the entry from meta-inf/services.

Sent from ProtonMail mobile

-------- Original Message --------
On 3 Nov 2018, 17:09, Chris Beams wrote:

> [@ManfredKarrer](https://github.com/ManfredKarrer) wrote:
>
>> Maybe [@blabno](https://github.com/blabno) find time to delist not traded coins.
>
> Sure. I could possibly do it too, just want to make sure we do it correctly.
>
>> I posted at a proposal the stats
>
> That's right. Here they are: [bisq-network/proposals#41 (comment)](https://github.com/bisq-network/proposals/issues/41#issue-367090734). That's a complete list (as of the date of the posting) of which coins should be delisted.
>
> Is it as simple as just removing the Asset implementations, though? Is there anything else we would need to do to put together a proper backward compatible PR? We talked about implementing delisting under the DAO as logical instead of physical deletion, but that's for the future. For right now, i.e. 0.9.0, I just want to delist this stuff in the simplest way possible while not breaking compatibility.
>
>> [...] and added code to easily print it out
>
> Can you provide a link to that code, and indicate how to run it if it's not obvious?
>
>> You are receiving this because you were mentioned.
> Reply to this email directly, [view it on GitHub](https://github.com/bisq-network/bisq/issues/1861#issuecomment-435599480), or [mute the thread](https://github.com/notifications/unsubscribe-auth/AAaT2FYLUmelJtJT_dVyfMeifxVylaofks5urb-wgaJpZM4YMxg8).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/1861#issuecomment-435600440
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20181103/6c8806bd/attachment.html>


More information about the bisq-github mailing list