[bisq-network/bisq] Torrc (#1893)

[Manfred Karrer]

ManfredKarrer commented on this pull request.



> @@ -257,6 +258,20 @@ private void createTorAndHiddenService(File torDir, int localPort, int servicePo
                     }
                 }
 
+                // check if the user wants to temporarily add to the default torrc file
+                LinkedHashMap<String, String> tmp = new LinkedHashMap<>();
+                System.getProperties().forEach((k, v) -> {
+                    if(((String) k).startsWith("torrc:"))
+                        tmp.put(((String) k).substring(6), (String) v);
+                });
+                if(!tmp.isEmpty())
+                    // check for custom torrcfile
+                    if(null != override)

Ah thanks for the link. 
With the case of NullPointerException I agree and also use it (e.g. "BTC".equals(code)) but with the asignment argument I think with a good IDE like IntelliJ mistakes should be easy to spot. 
Would prefer readiblity here. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/1893#discussion_r231699671
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20181107/7f0ab500/attachment.html>