[bisq-network/bisq] Resolve deprecated method in gradle-witness prior to moving to Gradle 5 (#1897)

Devin Bileck notifications at github.com
Thu Nov 8 06:55:00 UTC 2018


Before moving to Gradle 5, we will need to resolve the following deprecated method in gradle-witness:
```
> Configure project :desktop
The Task.leftShift(Closure) method has been deprecated and is scheduled to be removed in Gradle 5.0. Please use Task.doLast(Action) instead.
        at build_50pvy62xio1vz17f8pklhdf32.run(C:\Users\Devin\Documents\GitHub\devinbileck\bisq\desktop\build.gradle:18)
        (Run with --stacktrace to get the full stack trace of this deprecation warning.)
```

It is a [known issue](https://github.com/signalapp/gradle-witness/issues/22) that is still outstanding.

We may want to consider alternatives to gradle-witness since its last activity was Nov 2014. I found https://github.com/matthewtamlin/retrial as a potential candidate, which states:

> Retrial was created to address the unresolved issues in Open Whisper Systems' gradle-witness plugin, and to provide a more convenient means of storing dependency checksums.

However, @cbeams mentioned the following in https://github.com/bisq-network/bisq/issues/1815#issuecomment-435598615:

> This is a really easy problem to solve, and we're already working from my fork of gradle-witness, so we might want to just patch this one as well instead of moving to something entirely different.
> 
> Per the commit comment at 27cc933, the gradle-witness.jar we're using today is built from the PR at signalapp/gradle-witness#26 (which comes from my fork). So we can just further patch the code there, issue another pull request to the canonical repository (to be good citizens), and rebuild and check in the new jar.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/1897
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20181107/d334cd76/attachment.html>


More information about the bisq-github mailing list