[bisq-network/bisq] [WIP] Fixed netlayer and tor binary dependency issues (#1914)

[Chris Beams]

cbeams requested changes on this pull request.

NACK per comments. Minor stuff, but the Maven Central change is more than just a nit and should actually be changed. Also, please review rules 3 and 5 from the commit comment guidelines at https://github.com/bisq-network/style/issues/9 (no need to rebase/reword the commits in this PR, just for future reference). Thanks.

> @@ -37,9 +37,9 @@ configure(subprojects) {
     }
 
     repositories {
-        mavenCentral()

Please don't change this. There are issues with JCenter's SSL cert under OpenJDK 10, that's why I recently switched everything to Maven Central.

> @@ -37,9 +37,9 @@ configure(subprojects) {
     }
 
     repositories {
-        mavenCentral()
-        maven { url 'https://jitpack.io' }
-        maven { url 'https://raw.githubusercontent.com/JesusMcCloud/tor-binary/master/release/' }

Please don't kill the whitespace after the opening brace.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/1914#pullrequestreview-174509859
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20181113/dd3077e5/attachment.html>