[bisq-network/bisq] List LitecoinZ (LTZ) (#1910)

[Bernard Labno]

blabno requested changes on this pull request.

NACk per comments and no PRs from master

> @@ -21,8 +21,8 @@
  * Abstract base class for {@link Asset}s with their own dedicated blockchain, such as
  * {@link bisq.asset.coins.Bitcoin} itself or one of its many derivatives, competitors and
  * alternatives, often called "altcoins", such as {@link bisq.asset.coins.Litecoin},
- * {@link bisq.asset.coins.Ether}, {@link bisq.asset.coins.Monero} and
- * {@link bisq.asset.coins.Zcash}.
+ * {@link bisq.asset.coins.Ether}, {@link bisq.asset.coins.Monero}, {@link bisq.asset.coins.Zcash}

Do not touch this file

> @@ -144,6 +144,7 @@ public static void setBaseCurrencyCode(String baseCurrencyCode) {
         result.add(new CryptoCurrency("GRC", "Gridcoin"));
         if (!baseCurrencyCode.equals("LTC"))
             result.add(new CryptoCurrency("LTC", "Litecoin"));
+        result.add(new CryptoCurrency("LTZ", "LitecoinZ"));

Do not touch this file

> @@ -124,7 +124,7 @@ public void testGetUniqueListOfCryptoCurrencies() {
 
         preferences.readPersisted();
 
-        assertEquals(13, preferences.getCryptoCurrenciesAsObservable().size());
+        assertEquals(14, preferences.getCryptoCurrenciesAsObservable().size());

Do not touch this file

> @@ -170,6 +170,11 @@ private void onSaveNewAccount(PaymentAccount paymentAccount) {
                             .useIUnderstandButton()
                             .show();
                     break;
+                case "LTZ":

@cbeams do you think this is required?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/1910#pullrequestreview-175240943
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20181115/8377bb7c/attachment.html>