[bisq-network/bisq] Revise contributor / developer docs (#1924)

Chris Beams notifications at github.com
Thu Nov 15 10:27:09 UTC 2018


cbeams commented on this pull request.



> +
+## Contributor Workflow
+
+All Bisq contributors submit changes via pull requests. The workflow is as follows:
+
+ - Fork the repository
+ - Create a topic branch from the `master` branch
+ - Commit patches
+ - Submit a pull request from your topic branch back to the `master` branch of the main repository
+
+Pull requests should be focused on a single change. Do not mix, for example, refactorings with a bug fix or implementation of a new feature. This practice makes it easier for fellow contributors to review each pull request on its merits and and to give a clear ACK/NACK (see below).
+
+
+## Reviewing Pull Requests
+
+Bisq follows the review workflow established by the Bitcoin Core project. The following is adapted from the Bitcoin Core contributor documentation](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#peer-review):

Fixed in 7985ff7e0.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/1924#discussion_r233787321
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20181115/22c5b985/attachment.html>


More information about the bisq-github mailing list