[bisq-network/bisq] Can't edit order (#1732)

[Manfred Karrer]

@ripcurlx 

Nullpointer happened at the `PaymentAccount.fromProto` call:
```
PaymentAccount tmpPaymentAccount = user.getPaymentAccount(openOffer.getOffer().getMakerPaymentAccountId());
        TradeCurrency selectedTradeCurrency = CurrencyUtil.getTradeCurrency(openOffer.getOffer().getCurrencyCode()).get();

        this.paymentAccount = PaymentAccount.fromProto(tmpPaymentAccount.toProtoMessage(), corePersistenceProtoResolver);

        if (paymentAccount.getSingleTradeCurrency() != null)
            paymentAccount.setSingleTradeCurrency(selectedTradeCurrency);
        else
            paymentAccount.setSelectedTradeCurrency(selectedTradeCurrency);
```

To add a null check would be good but would likely lead to further issues if the paymentAccount is not set. Basically it should not be possible that the paymentAccount is not found as one cannot delete a paymentAccount if there are open offers. Maybe the check there does not cover deactivated offers?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/1732#issuecomment-439635647
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20181117/01c99723/attachment.html>