[bisq-network/bisq] Can launch Bisq only after system restart on Windows (#1943)

[Florian Reimair]

This issue might address #1023, #1161, possibly #791 and more recent reports even from @ManfredKarrer himself. The issue is meant as a progress tracker.

### Issue
Bisq gets started. Bisq runs. Bisq gets closed and exists gracefully (?). Nothing wrong yet.
Now, Bisq gets started again, and it refuses to start with:
```
ERROR i.b.n.p.n.TorNetworkNode: Tor node creation failed: java.lang.RuntimeException: Could not delete file C:\Users\Name\AppData\Roaming\Bisq\btc_mainnet\tor\lock 
```
### Affected platforms
Windows

### Findings so far
The Tor process creates a file named `lock` in the Tor working directory. It has size 0 (as expected for a lock file), gets created as soon as the tor-binary is executed, and is in turn owned by the Tor process. However, at least on my Arch linux machine, the file does not get deleted after Tor shutdown and is only overwritten on a fresh start of Tor.

Ah yes, and this behaviour does apply to bisq, the netlayer tests and the TorBrowser-bundle as well. It seems like the issue might be located in Tor itself.

### Help needed
I cannot reproduce the issue right now. However, if anyone stumbles upon the issue, please check if a Tor process is still running on your machine. If so, try force-killing the process and start Bisq again.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/1943
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20181119/a7cf3ef5/attachment-0001.html>