[bisq-network/bisq] List Bitcoin Rhodium (XRC) (#1944)

[Chris Beams]

cbeams requested changes on this pull request.

NACK per comments. Do not add coins / tokens to the list of main cryptocurrencies. Doing so is not part of the instructions at https://bisq.network/list-asset.

> @@ -145,6 +145,7 @@ public static void setBaseCurrencyCode(String baseCurrencyCode) {
         if (!baseCurrencyCode.equals("LTC"))
             result.add(new CryptoCurrency("LTC", "Litecoin"));
         result.add(new CryptoCurrency("XMR", "Monero"));
+        result.add(new CryptoCurrency("XRC", "Bitcoin Rhodium"));

```suggestion
```

> @@ -124,7 +124,7 @@ public void testGetUniqueListOfCryptoCurrencies() {
 
         preferences.readPersisted();
 
-        assertEquals(13, preferences.getCryptoCurrenciesAsObservable().size());
+        assertEquals(14, preferences.getCryptoCurrenciesAsObservable().size());

```suggestion
        assertEquals(13, preferences.getCryptoCurrenciesAsObservable().size());
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/1944#pullrequestreview-176699633
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20181120/3c40077f/attachment.html>