[bisq-network/bisq] Quell help output on option parsing error (#1955)

Chris Beams notifications at github.com
Fri Nov 23 08:12:35 UTC 2018


This change suppresses help output when option parsing fails, e.g. due
to an unrecognized option being specified. This is in keeping with *nix
utility idioms; for example, notice what happens when running `git
--bogus` or `ls --bogus`: they output an error message, and in some
cases a usage message, but they do not print complete help text.
This approach is especially important in the case of an application like
Bisq, where there are many options and the help text is longer than a
typical screen, making it easy to miss the error message altogether, as
it is printed at the top of the screen.

This change also prints the error message to stderr vs stdout, which is
again in keeping with *nix utility idoms.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/1955

-- Commit Summary --

  * Quell help output on option parsing error

-- File Changes --

    M core/src/main/java/bisq/core/app/BisqExecutable.java (8)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/1955.patch
https://github.com/bisq-network/bisq/pull/1955.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/1955
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20181123/18b373ea/attachment.html>


More information about the bisq-github mailing list