[bisq-network/bisq] Add advanced cash payment method (#1957)

Jeffrey Ko notifications at github.com
Fri Nov 23 14:18:07 UTC 2018


closes #1876 and closes #1785

A couple notes about this:

1. In addition to RUB, USD, EUR, GBP as described, Advanced pay also supports UAH, KZT and BRL.  These were included in the currency dropdown as well.
2. All wallet id's follow the form X000000000000 (a letter followed by 12 numbers, confirmed with advanced pay devs) so validation was added for this.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/1957

-- Commit Summary --

  * Add advanced cash payment method

-- File Changes --

    M common/src/main/proto/pb.proto (6)
    A core/src/main/java/bisq/core/payment/AdvancedCashAccount.java (46)
    M core/src/main/java/bisq/core/payment/PaymentAccountFactory.java (2)
    A core/src/main/java/bisq/core/payment/payload/AdvancedCashAccountPayload.java (104)
    M core/src/main/java/bisq/core/payment/payload/PaymentMethod.java (3)
    M core/src/main/java/bisq/core/proto/CoreProtoResolver.java (3)
    M core/src/main/resources/i18n/displayStrings.properties (6)
    A desktop/src/main/java/bisq/desktop/components/paymentmethods/AdvancedCashForm.java (77)
    M desktop/src/main/java/bisq/desktop/components/paymentmethods/GeneralAccountNumberForm.java (11)
    M desktop/src/main/java/bisq/desktop/main/account/content/fiataccounts/FiatAccountsView.java (7)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/buyer/BuyerStep2View.java (4)
    A desktop/src/main/java/bisq/desktop/util/validation/AdvancedCashValidator.java (36)
    A desktop/src/test/java/bisq/desktop/util/validation/AdvancedCashValidatorTest.java (38)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/1957.patch
https://github.com/bisq-network/bisq/pull/1957.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/1957
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20181123/52bd1369/attachment.html>


More information about the bisq-github mailing list