[bisq-network/bisq] Fix broken startScripts in $destinationDir/bin dirs (#1979)

[Florian Reimair]

A recent change in the build procedure produces broken startScripts in the respective `$destinationDir/bin`-directories.

### Issue
startScripts located in `$destinationDir/bin`-directories yield
```
Error: Could not find or load main class bisq.desktop.app.BisqAppMain
Caused by: java.lang.ClassNotFoundException: bisq.desktop.app.BisqAppMain
```
when executed.

### Cause
The startScripts get changed in order to be executed in the project root directory. However, they get changed before they are copied and thus, the original startScripts (still located in the `$destinationDir/bin`-directories) have a wrong path prefix for the classpath declaration (i.e. `.../bin/lib/...` instead of `.../bin/../lib/...`)

### Fix
First copy the startScripts to `rootProject.projectDir` and only then change them.

### Notes
- I believe that every startScript should work, regardless where it resides (even when its use is somewhat deprecated)
- I stumbled over the issue while fixing the [AUR bisq-git package](https://aur.archlinux.org/packages/bisq-git/) (doing my duty https://github.com/bisq-network/roles/issues/78)
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/1979

-- Commit Summary --

  * Fix broken executables in /bin dirs

-- File Changes --

    M build.gradle (22)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/1979.patch
https://github.com/bisq-network/bisq/pull/1979.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/1979
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20181127/74730dd7/attachment-0001.html>