[bisq-network/bisq-docs] [WIP] Add Bitcoin Core Node role doc (#92)

Chris Beams notifications at github.com
Tue Nov 27 14:43:39 UTC 2018


cbeams approved this pull request.

ACK

> +
+=== Step 0. Evaluate
+
+Determine if this is really a role you can fill. It's expected that your node will maintain (1) good uptime and (2) an up-to-date config and bitcoind version (as required by the Bitcoin Node Maintainer). There are no strict requirements for either, but it's expected that you will make your best effort to stay current.
+
+=== Step 1. Get in Touch
+
+Contact the Bitcoin Core Maintainer to convey your intention of setting up a Bitcoin Core node for Bisq.
+
+=== Step 2. Set it Up
+
+Set up a Bitcoin Core node, making sure to use the configuration https://github.com/bisq-network/bisq-btcnode[specified here] [where is it, actually?]. Also make sure your node runs in a secure environment [ details? ] and that it allows onion connections so Bisq can connect to it.
+
+=== Step 3. Include Node in Bisq Source
+
+Once your node is ready, send a PR to include it as a Bitcoin Core node for Bisq (they're currently specified https://github.com/bisq-network/bisq/blob/ff4e22d5f537ec8e77bffb3fec116b96fa387c46/core/src/main/java/bisq/core/btc/nodes/BtcNodes.java[here]).

Nit: probably better to make links like this refer to `master` vs. a specific commit, just so when they click the link, they get an up-to-date view on things. The downside of course is that if that class is moved or renamed, the link will not work anymore.

> @@ -53,6 +53,7 @@ Docs without hyperlinks haven't been written yet. If you want to write one, <<co
  * <<manual-dispute-payout#, How to issue a manual dispute payout>>
  * <<exchange/howto/run-seednode#, How to run a seednode>>
  * <<exchange/howto/run-price-relay-node#, How to run a pricenode>>
+ * <<btcnode#, Bitcoin Node Maintainer Role>>

Nit: Probably good to nest this under the 'Roles' item or to create a separate subsection called 'Roles'. Refer to the OmniOutliner doc I sent you earlier, @m52go. Not worth holding this PR up though. Just mentioning for the future.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-docs/pull/92#pullrequestreview-178818117
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20181127/fc3b6ec4/attachment.html>


More information about the bisq-github mailing list