[bisq-network/bisq] Bug fixes dao (#2016)

[sqrrm]

sqrrm approved this pull request.

utACK

> @@ -164,20 +164,29 @@ protected void activate() {
 
         payFeeButton.setOnAction((event) -> {
             Coin listingFee = getListingFee();
-            try {
-                Transaction transaction = assetService.payFee(selectedAsset, listingFee.value);
-                Coin miningFee = transaction.getFee();
-                int txSize = transaction.bitcoinSerialize().length;
-
-                if (!DevEnv.isDevMode()) {
-                    GUIUtil.showBsqFeeInfoPopup(listingFee, miningFee, txSize, bsqFormatter, btcFormatter,
-                            Res.get("dao.burnBsq.assetFee"), () -> doPublishFeeTx(transaction));
-                } else {
-                    doPublishFeeTx(transaction);
+            long days = getDays();
+            // We don't allow shorter periods as it would allow an attacker to try to deactivate other coins by making a
+            // small fee payment to reduce the trial period and look back period.
+            // Still not a perfect solution but should be good enough for now.

Good point about an attacked reducing the listing period of a coin. Perhaps we should consider not allowing a shorter period than the one initially chosen when doing a reactivation? It solves this problem and doesn't really reduce usability.

> @@ -110,6 +110,16 @@
     // Min required trade volume to not get de-listed. Check starts after trial period and use trial period afterwards to look back for trade activity.
     ASSET_MIN_VOLUME("0.01", ParamType.BTC, 10, 10),
 
+  /*  // TODO for testnet we want to have a short cycle of about a week

This only adds up to 5+ days. Still ok, but proposal phase could be extended to 600 blocks to make it 7 days.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2016#pullrequestreview-180411713
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20181130/5e38f36f/attachment.html>