[bisq-network/bisq] Bug fixes dao (#2016)

[Manfred Karrer]

ManfredKarrer commented on this pull request.



> @@ -164,20 +164,29 @@ protected void activate() {
 
         payFeeButton.setOnAction((event) -> {
             Coin listingFee = getListingFee();
-            try {
-                Transaction transaction = assetService.payFee(selectedAsset, listingFee.value);
-                Coin miningFee = transaction.getFee();
-                int txSize = transaction.bitcoinSerialize().length;
-
-                if (!DevEnv.isDevMode()) {
-                    GUIUtil.showBsqFeeInfoPopup(listingFee, miningFee, txSize, bsqFormatter, btcFormatter,
-                            Res.get("dao.burnBsq.assetFee"), () -> doPublishFeeTx(transaction));
-                } else {
-                    doPublishFeeTx(transaction);
+            long days = getDays();
+            // We don't allow shorter periods as it would allow an attacker to try to deactivate other coins by making a
+            // small fee payment to reduce the trial period and look back period.
+            // Still not a perfect solution but should be good enough for now.

So then they only can use same or larger amounts in fee for future payments. We can change those parts anyway later as they are not really consensus part. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2016#discussion_r237989830
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20181130/8f9ba4d3/attachment.html>