[bisq-network/bisq] Asset Validation Override in Coin Extensions (#2021)

[CaveSpectre11]

Several coins, likely starting with PIVX, have errors in the the address validation regular expression; notably the leading character check wasn't deducted from the count of the following characters; so the address validation will incorrectly accept 35 character addresses.

The invalid address checks in Test all contain an invalid first character; therefore the only part of the regex tested is that leading character; so while other test addresses were meant to cover length and other invalid characters; none of the test parsing passed the first character test.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/2021
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20181130/2092e64c/attachment.html>