[bisq-network/bisq] Dao fixes (#1738)

sqrrm notifications at github.com
Wed Oct 3 14:42:24 UTC 2018


sqrrm approved this pull request.

utACK

> @@ -243,14 +259,9 @@ private void onAppendOnlyDataAdded(PersistableNetworkPayload persistableNetworkP
             if (!proposalPayloads.contains(proposalPayload)) {
                 Proposal proposal = proposalPayload.getProposal();
                 if (proposalValidator.areDataFieldsValid(proposal)) {
-                    if (proposalValidator.isTxTypeValid(proposal)) {
-                        proposalPayloads.add(proposalPayload);
-                        log.info("We received a ProposalPayload and store it to our appendOnlyStoreList. proposalTxId={}",
-                                proposal.getTxId());
-                    } else {
-                        log.warn("We received a proposal with an invalid txId. Proposal.txId={}",
-                                proposal.getTxId());
-                    }
+                    proposalPayloads.add(proposalPayload);

Could this be a potential attack vector, spamming invalid proposals that persist indefinitely?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/1738#pullrequestreview-161192462
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20181003/f3f014f6/attachment.html>


More information about the bisq-github mailing list