[bisq-network/bisq] Dao improvements (#1746)

[sqrrm]

sqrrm commented on this pull request.



>       */
     public int getLockTime() {
         return txOutputs.get(0).getLockTime();
     }
 
+    /**
+     * The unlockBlockHeight is stored in the LOCKUP txOutput, which is the first txOutput.

I would've thought it more natural to store the unlockBlockHeight in the UNLOCK txOutput since it's only then that the unlockBlockHeight is known. It's also when spending the UNLOCK txOutput that the check for current blockheght vs unlockBlockHeight is relevant.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/1746#discussion_r222822830
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20181004/f150ac38/attachment.html>