[bisq-network/bisq-docs] Implement pedromvpg's 2018 redesign (#89)

[Chris Beams]

cbeams requested changes on this pull request.

NACK, because I think we can do better on implementing the `stylesdir` attribute. See below.

First let me say though, the changes themselves look great. It's a pleasure to read and scroll through the docs. Nice work.

I expected the Bisq logo at the top left to take me back to https://bisq.network. Has that been considered?

With regard to `:stylesdir:` and relative pathing, I've actually long wanted to flatten out the directory hierarchy. There are only a few docs that sit in nested directories anyway, and they're the outliers. Perhaps we should take this opportunity to change that, and put proper redirects in place. I wouldn't actually recommend doing so as part of this PR, but we could do it right afterward, or after all of this goes live.

If all docs live at the top level, then we can just move the `:stylesdir: ./css` attribute to `build.gradle` as well, so that it doesn't need to be repeated in every file like it is now. And in fact, we can make that change now, and simply override the `:stylesdir:` attribute where necessary in the files that live in nested dirs. So this is the change that I'm suggesting gets made before merging this PR.

Nit: `lean-and-green.css` is colorful naming, but I would have gone with something simpler like `bisq.css`. The latter better indicates a general departure from Asciidoc's standard css, and (while pretty theoretical) if the color scheme were to change to something other than green, the name of the file (`bisq.css`) would not need to be changed (to `mean-and-tangerine.css` or whatever).

Kudos, by the way on figuring out how to navigate Asciidoc's CSS handling. I've found it quite frustrating in the past as well, and am surprised to see how simply these changes have been applied here.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-docs/pull/89#pullrequestreview-162600525
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20181008/d8e6c78c/attachment.html>