[bisq-network/bisq] Bisq doesn't validate XMR addresses (#1652)
The Blur Network
notifications at github.com
Wed Oct 10 22:28:35 UTC 2018
After discussing a bit with @Technohacker, and tooling around with the Address Tests on xmr.llcoins.net . . . It turns out that the public address for any cryptonote coin with a "prefix length" of 2 characters will fail the tests provided by CryptonoteAddressValidator in #1683.
When a netbyte for a given currency (b201 in Aeon, or cd3c for Blur) is four characters, it seems that the base58 encoding for cryptonote will result in a 97-character public address.
I'm going to add a conditional statement to the CryptonoteAddressValidator, and force push the changes to the already opened PR #1723 for listing of BLUR.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/1652#issuecomment-428754980
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20181010/92e2697b/attachment.html>
More information about the bisq-github
mailing list