[bisq-network/bisq] Workaround for JDK-8199592; text being truncated at certain display scaling levels (#1767)

Devin Bileck notifications at github.com
Thu Oct 11 07:05:01 UTC 2018


Using display scaling (e.g. 150% in Windows 10), text content within popups were being truncated.
A couple examples:
![image](https://user-images.githubusercontent.com/603793/46785717-8541e500-cce7-11e8-942d-b2e50d86de61.png)

![image](https://user-images.githubusercontent.com/603793/46785774-aa365800-cce7-11e8-92c2-31feed89e4f5.png)

This is a result of a known Java bug (https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8199592) which mentions a workaround:
> explicitly calling sizeToScene appears to suppress the bug at DPI levels other than 175%

I confirmed that this workaround fixes the truncation at 125% and 150% scaling, but noticed it still truncates the checkbox label at 175% (as stated in the workaround):
![image](https://user-images.githubusercontent.com/603793/46785899-0b5e2b80-cce8-11e8-832b-0ee18dec25c5.png)
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/1767

-- Commit Summary --

  * Workaround for labels being truncated at certain display scaling levels (JDK-8199592)

-- File Changes --

    M desktop/src/main/java/bisq/desktop/main/overlays/Overlay.java (1)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/1767.patch
https://github.com/bisq-network/bisq/pull/1767.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/1767
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20181011/771834b5/attachment.html>


More information about the bisq-github mailing list