[bisq-network/bisq] Dao ui improvements (#1751)

[sqrrm]

sqrrm approved this pull request.

utACK

Some comments on parts that might need more documentation but please go ahead and merge.

> @@ -173,6 +189,24 @@ public void onFault(String errorMessage, @Nullable Connection connection) {
             } else {
                 log.warn("We have stopped already. We ignore that onMessage call.");
             }
+        } else if (networkEnvelope instanceof RepublishBlindVotesRequest) {
+            ObservableList<BlindVotePayload> appendOnlyStoreList = blindVoteListService.getAppendOnlyStoreList();
+            appendOnlyStoreList
+                    .forEach(blindVotePayload -> {
+                        // We want a random delay between 0.1 and 30 sec. depending on the number of items

What's the reason to depend on the number of items?

>  
-    // 0.05 BSQ (5 satoshi) for a 1 BTC trade -> 0.005%. 0.05 USD if 1 BSQ = 1 USD, 10 % of BTC fee
-    private static final long MIN_MAKER_FEE_BSQ = 5;
-    private static final long MIN_TAKER_FEE_BSQ = 5;
-    // 2 BSQ or 200 BSQ-satoshi. About 2 USD if 1 BSQ = 1 USD for a 1 BTC trade which is about 10% of a normal BTC fee.
-    private static final long DEFAULT_TAKER_FEE_BSQ = 200;
-    private static final long DEFAULT_MAKER_FEE_BSQ = 200;
+    public static Coin getMakerFeePerBtc(boolean currencyForFeeIsBtc) {

This is a bit confusing. Probably better to have separate methods for the two coins. If necessary to have just one method it should be clear what the Coin returned might be.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/1751#pullrequestreview-164416348
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20181012/8dec04cb/attachment-0001.html>