[bisq-network/bisq] Take offer screen layout issue (#1742)

[Manfred Karrer]

It is a bit tricky.
If there is an offer with range we show the edit amount screen with a next button and then the animation and label text for checking if the peer is online is all fine as the funding screen is not visible before the user clicks the next button and that is only possible after the offer availibility check has succeeded (the label and spinner animation is hidden).
If there is only a fixed amount (offer min amount = offer amount) then we dont need to make that extra step for the user and we show directly the funding screen as the user cannot edit anything in the amount screen. And here the bug got introduced that the layout for the offer availibility check is not updated. In dev mode with regtest you usually dont see that as the offer availibility check gets executed very fast. with real tor connections that can take seconds or even 1 min (timeout).

I am not 100% sure whats the best solution here is, but it should be clearly visible to the user as the offer availibility check is important, so that the user does not fund his wallet from an external wallet before that is successful, otherwise it can be that the offer is not available (either peer is offline or someone else took the offer in the meantime) and the user has made a tx to his bisq wallet from an external wallet. if he used the internal wallet transfer the damage is lower as no tx is created in that case, but still would confuse usability. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/1742#issuecomment-429940852
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20181015/401079e2/attachment-0001.html>