[bisq-network/bisq] Persitence of DAO state (#1778)
sqrrm
notifications at github.com
Thu Oct 18 20:03:33 UTC 2018
sqrrm approved this pull request.
utACK
> @@ -916,7 +916,7 @@ message PersistableEnvelope {
UserPayload user_payload = 10;
PaymentAccountList payment_account_list = 11;
- BsqState bsq_state = 12;
+ // BsqState bsq_state = 12; // not used but as other non-dao data have a higher index number we leave it to make clear that we cannot change following indexes
Just comment with `deprecated` or some such to make it clearer I think.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/1778#pullrequestreview-166268402
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20181018/b5cdd8b3/attachment.html>
More information about the bisq-github
mailing list