[bisq-network/bisq] Use OpenJDK10 (#1794)

Chris Beams notifications at github.com
Sat Oct 20 13:41:55 UTC 2018


cbeams requested changes on this pull request.

NACK per inline comments; all fairly minor stuff. Thanks for putting this together, @devinbileck.

> @@ -1,5 +1,5 @@
 language: java
-jdk: oraclejdk10
+jdk: openjdk10

Glad to see this works without the `install-jdk.sh` bit.

> @@ -1,12 +1,27 @@
+buildscript {
+    repositories {
+        mavenCentral()
+    }
+    dependencies {
+        classpath 'com.google.gradle:osdetector-gradle-plugin:1.6.0'
+    }
+}
+
 plugins {
     id 'java'
     id 'maven'
     id 'com.google.protobuf' version '0.8.5'

Add the following line here, and delete the `buildscript` block above:

    id 'com.google.osdetector' version '1.6.0'

(Per https://github.com/google/osdetector-gradle-plugin#for-gradle-21-and-higher)

>  plugins {
     id 'java'
     id 'maven'
     id 'com.google.protobuf' version '0.8.5'
 }
 
+apply plugin: 'application'

Why?

>  plugins {
     id 'java'
     id 'maven'
     id 'com.google.protobuf' version '0.8.5'
 }
 
+apply plugin: 'application'
+apply plugin: 'com.google.osdetector'

Remove along with the `buildscript` block.

>  group = 'network.bisq'
 version = '-SNAPSHOT'
 
+mainClassName = 'bisq.common'

This isn't the name of a class. Assuming you remove the `application` plugin as suggested above, this should be removed too.

> @@ -19,6 +34,7 @@ tasks.withType(JavaCompile) {
 
 repositories {
     jcenter()
+    mavenCentral()

Everything resolvable from Maven Central should also be resolvable from JCenter. Did that not prove true for you? Please remove `mavenCentral()` references here and everywhere else if possible.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/1794#pullrequestreview-166749741
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20181020/c59d045d/attachment-0001.html>


More information about the bisq-github mailing list