[bisq-network/bisq] List pasc-coin (#1676)

[Charles Bentley]

You were right. a few edge cases were not covered in the **public void testInvalidAddresses()**

Add those lines will fix it

     ```
        //checksum with characters
        assertInvalidAddress("3532-zZ");

        //trailing dash
        assertInvalidAddress("0-");
        assertInvalidAddress("-");

        //too big a number
        assertInvalidAddress("1000000000");
        assertInvalidAddress("1000000000-46");

```
Code coverage will show that there is a catch that never actually run. 
```
   } catch (StringIndexOutOfBoundsException e) {
                return AddressValidationResult.invalidAddress(ERROR_INVALID_CHECKSUM_STRUCTURE);
   }
```
It was put there as a defensive measure.

What do you want me to do?
          
Cheers

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/1676#issuecomment-431591929
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20181020/82db41b6/attachment.html>