[bisq-network/bisq] Dao UI improvements (#1795)

[Christoph Atteneder]

ripcurlx requested changes on this pull request.

utACK - besides some minor changes

> @@ -358,16 +360,92 @@ public void publishBlindVote(Coin stake, ResultHandler resultHandler, ExceptionH
     // Use case: Presentation of phases
     ///////////////////////////////////////////////////////////////////////////////////////////
 
-    public int getFirstBlockOfPhase(int height, DaoPhase.Phase phase) {
-        return periodService.getFirstBlockOfPhase(height, phase);
-    }
-
-    public int getLastBlockOfPhase(int height, DaoPhase.Phase phase) {
-        return periodService.getLastBlockOfPhase(height, phase);
-    }
-
-    public int getDurationForPhase(DaoPhase.Phase phase) {
-        return periodService.getDurationForPhase(phase, daoStateService.getChainHeight());
+    // Because last block in request and voting phases must not be used fo making a tx as it will get confirmed in the

Typo:
> fo --> for

> +            case BREAK2:
+                firstBlock++;
+                break;
+            case VOTE_REVEAL:
+                break;
+            case BREAK3:
+                firstBlock++;
+                break;
+            case RESULT:
+                break;
+        }
+
+        return firstBlock;
+    }
+
+    // Because last block in request and voting phases must not be used fo making a tx as it will get confirmed in the

Typo:
> fo --> for

> +                lastBlock--;
+                break;
+            case BREAK2:
+                break;
+            case VOTE_REVEAL:
+                lastBlock--;
+                break;
+            case BREAK3:
+                break;
+            case RESULT:
+                break;
+        }
+        return lastBlock;
+    }
+
+    // Because last block in request and voting phases must not be used fo making a tx as it will get confirmed in the

Typo:
> fo --> for

>              throws ValidationException, InsufficientMoneyException, TxException {
         this.requestedBsq = requestedBsq;
-        this.bsqAddress = bsqAddress;
+        this.bsqAddress = "B" + bsqWalletService.getUnusedAddress().toBase58();

:+1:

> @@ -1291,7 +1291,7 @@ dao.wallet.menuItem.send=Senden
 dao.wallet.menuItem.receive=Empfangen
 dao.wallet.menuItem.transactions=Transaktionen
 
-dao.wallet.dashboard.statistics=Statistiken
+dao.wallet.dashboard.distribution=Statistiken

You don't need to bother about changing translations except displayStrings.properties. All other files will be overwritten by the Transifex state. So if we change keys that have been translated yet we need to copy it over in Transifex. Have to see how easy this is visible in the interface. I'll also have to walk over all supported translations with the redesign branch as lots of ":" in translations need to be removed.

>          if (phase == DaoPhase.Phase.PROPOSAL) {
-            icon = AwesomeDude.createIconLabel(AwesomeIcon.FILE_TEXT);
+            //icon = AwesomeDude.createIconLabel(AwesomeIcon.TRASH);
+            icon = AwesomeDude.createIconLabel(AwesomeIcon.TRASH);

Please use `Formbuilder.getIcon` so it is easier when we need to switch to the newest AwesomeDude library.

>          resyncDaoButton.setOnAction(e -> daoFacade.resyncDao(() -> {
             new Popup<>().attention(Res.get("setting.preferences.dao.resync.popup"))
                     .useShutDownButton()
                     .hideCloseButton()
                     .show();
         }));
+
+        isDaoFullNodeCheckBox.setOnAction(e -> {
+            String key = "daoFullModeInfoShown";
+            if (isDaoFullNodeCheckBox.isSelected() && preferences.showAgain(key)) {
+                String url = "https://bisq.network/docs/dao-full-node";

Maybe we could think about moving all URLs into one place so they get easier to maintain when the structure in the docs is changed.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/1795#pullrequestreview-167402654
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20181023/48037711/attachment-0001.html>