[bisq-network/bisq] Dao UI improvements (#1795)
Manfred Karrer
notifications at github.com
Tue Oct 23 16:51:12 UTC 2018
ManfredKarrer commented on this pull request.
> - return periodService.getLastBlockOfPhase(height, phase);
- }
-
- public int getDurationForPhase(DaoPhase.Phase phase) {
- return periodService.getDurationForPhase(phase, daoStateService.getChainHeight());
+ // Because last block in request and voting phases must not be used fo making a tx as it will get confirmed in the
+ // next block which would be already the next phase we hide that last block to the user and add it to the break.
+ public int getFirstBlockOfPhaseForDisplay(int height, DaoPhase.Phase phase) {
+ int firstBlock = periodService.getFirstBlockOfPhase(height, phase);
+ switch (phase) {
+ case UNDEFINED:
+ break;
+ case PROPOSAL:
+ break;
+ case BREAK1:
+ firstBlock++;
Yes, should rename the var or refactor it so its less hacky...
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/1795#discussion_r227476378
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20181023/9712868e/attachment.html>
More information about the bisq-github
mailing list