[bisq-network/bisq] Cleanup gradle config (#1808)

Devin Bileck notifications at github.com
Tue Oct 23 23:19:34 UTC 2018


I made a few changes at an attempt to cleanup and reorganize some of the gradle config.

- Remove duplicate openjfx dependencies in common/build.gradle.
- Use latest Gradle (4.10.2).
- Move desktop/gradle files to root gradle folder. Rather than having a gradle folder underneath the desktop folder, put its content in the root gradle folder to reduce duplication and have a single location for gradle content.
- Define some of the common buildscript dependencies in the root build.gradle so as
to reduce duplication and easier maintenance (i.e. updating version numbers). Gradle build files within sub folders should be able to apply these plugins without also having to define them as a dependency first. **I am not sure if this is a desired change. Feedback appreciated!**
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/1808

-- Commit Summary --

  * Remove duplicate dependencies
  * Move desktop/gradle files to root gradle folder
  * Use gradle-4.10.2
  * Move common buildscript dependencies to root build.gradle
  * Remove unnecessary compileJava and Run blocks
  * Merge remote-tracking branch 'upstream/master' into cleanup-gradle-config
  * Add missing javafx dependencies

-- File Changes --

    M build.gradle (11)
    M common/build.gradle (20)
    M desktop/build.gradle (11)
    D desktop/gradle/wrapper/gradle-wrapper.jar (0)
    D desktop/gradle/wrapper/gradle-wrapper.properties (6)
    R gradle/witness/README.md (0)
    R gradle/witness/gradle-witness.jar (0)
    M gradle/wrapper/gradle-wrapper.properties (2)
    M seednode/build.gradle (9)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/1808.patch
https://github.com/bisq-network/bisq/pull/1808.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/1808
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20181023/8d5ebe74/attachment.html>


More information about the bisq-github mailing list