[bisq-network/bisq] Add PromptPay (Thailand) (#1831)

Manfred Karrer notifications at github.com
Sun Oct 28 17:42:19 UTC 2018


ManfredKarrer approved this pull request.

ACK

Thanks a lot for addint it! Dont forget to file a compensation request at https://github.com/bisq-network/compensation/issues

> @@ -227,6 +229,9 @@ public PaymentMethod(String id, long maxTradePeriod, @NotNull Coin maxTradeLimit
                     ALI_PAY = new PaymentMethod(ALI_PAY_ID, DAY, maxTradeLimitLowRisk),
                     WECHAT_PAY = new PaymentMethod(WECHAT_PAY_ID, DAY, maxTradeLimitLowRisk),

Is that really a low risk payment method? Those are the ones where chargeback risk is super low or even stated that it is not possible to do chargeback. If so great, otherwise maybe better to use the mid risk parameter.

> @@ -227,6 +229,9 @@ public PaymentMethod(String id, long maxTradePeriod, @NotNull Coin maxTradeLimit
                     ALI_PAY = new PaymentMethod(ALI_PAY_ID, DAY, maxTradeLimitLowRisk),
                     WECHAT_PAY = new PaymentMethod(WECHAT_PAY_ID, DAY, maxTradeLimitLowRisk),

Ah I just read the comment in the issue. Seems its really low risk. So lets keep it.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/1831#pullrequestreview-169099029
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20181028/65b848d3/attachment.html>


More information about the bisq-github mailing list