[bisq-network/bisq] Verify dao param default vals #1769 (#1824)

[Manfred Karrer]

ManfredKarrer requested changes on this pull request.

I could not add the comment to the code directly...

I would prefer to not have class fieds in the test as that makes the test more complex. Would prefer also to keep the formatter out completely as its an injected object. The test cannot be run atm in the IDEA without extra setup (jvm args) as the mockit framework has issues with the recent java 10 update.... I know we have other tests as well where that is the case but I prefer that new tests are as functional style as possible (e.g. simple input simple output). The formatting can be done in the caller and that does not need to be tested.

In the test there are some unused fields, please remove those.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/1824#pullrequestreview-169102545
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20181028/6b3d4eed/attachment-0001.html>