[bisq-network/bisq] Add BTC address param, use String for param value instead of long (#1841)

Manfred Karrer notifications at github.com
Wed Oct 31 00:03:32 UTC 2018


ManfredKarrer commented on this pull request.



> @@ -770,7 +773,22 @@ public void setNewParam(int blockHeight, Param param, long paramValue) {
                 });
     }
 
-    public long getParamValue(Param param, int blockHeight) {
+    public Coin getParamValueAsCoin(Param param, int blockHeight) {

you mean to check the type? as they are called only from switch cases by type i am not sure if its needed. would throw exceptions otherwise...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/1841#discussion_r229528228
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20181030/a785b5f7/attachment-0001.html>


More information about the bisq-github mailing list