[bisq-network/bisq-desktop] Create mono repository (#1650)

Chris Beams notifications at github.com
Wed Sep 5 15:16:22 UTC 2018


cbeams approved this pull request.

ACK. Thanks so much for putting this together, @chirhonul and @ripcurlx.

There are a few changes I'd like to make to the readme regarding instructions for building and importing into IDEA, but don't have the time just now. @ManfredKarrer is traveling, so I'm not sure if he'll have time to review. I'll leave it to you when to merge. I can get my changes in by tomorrow for sure, but they can also be done as a separate PR.

I'll also rearrange the names of the repositories once this is merged, renaming the current `bisq-network/bisq` to something that gets it out of the way and renaming `bisq-network/bisq-desktop` to `bisq-network/bisq`. Sound good?

As I've said before, there are various improvements to the build that we can do to make it a more idiomatic multi-project build, but they can all come afterward. As it is, everything builds and imports cleanly for me (with the right instructions that I'll add to the readme), so thumbs up from my side.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-desktop/pull/1650#pullrequestreview-152549019
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20180905/4097e7cb/attachment.html>


More information about the bisq-github mailing list