[bisq-network/bisq] Fix Monero address validation (#1652) (#1683)
matt2134711
notifications at github.com
Thu Sep 13 17:37:39 UTC 2018
matt2134711 requested changes on this pull request.
[Monero addresses are encoded in base58](https://github.com/monero-project/monero/blob/master/src/common/base58.cpp), so using `[0-9A-Za-z]` would still let some bad characters through (`0`, `I`, `O`, and `l` are never in an address).
Also the last few bytes are a checksum so it would be nice if that was validated.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/1683#pullrequestreview-155192960
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20180913/fb67d18e/attachment.html>
More information about the bisq-github
mailing list