[bisq-network/bisq] Porting Manfred's HTTP API changes from bisq-core to the mono repo (#1686)

[Manfred Karrer]

They touch quite a few important areas (offer creation, tx fee estimation,...). When I have more time I will test it more carefully and for the next planned release mid October we will have a big test iteration anyway. So I would prefer to get it into that release but on a dev-test branch not on master to keep master low risk with potential bugs from not sufficiently tested code.

But why you need it in master? You can just fork Bisq master and add it there. We will keep that fork then as the API working base and once its time for getting a PR ready we will test and merge it into master.

I discussed a few weeks back with @blabno about a minimal API version what we can launch realistically. That should contain only the absolute min. set of features for a trader who wants to run a trading bot. I see those features limited to: 
- Offer creation
- Take offer
- Trade state changes (e.g. payment sent, etc)

I will not have time to review and test the whole API code soon, that would just take too much of my time and it is too critical and risky to get launched without very careful review and testing (not only for the API use but also to users who take an offer from an API user). We need to refactor also all the code duplication parts, I found several bugs there caused from not being in sync with master. That carries just too much risk and once it merged it likely will stay a technical debt and cause more problems in future. Most of those refactorings are rather trivial (moving code to core util classes or domain specific classes). Some are more complex (like the refactoring for fee estimation I did).

So the only way forward I see is to launch in iterations and keep the other features by default deactivated and if the user wants to activate it he gets a big warning that it is not tested and that he not only risks his funds but also can cause problems for other users (takers).
For the integration test all features can be activated, I am only referring to normal API users who should be limited to those areas which are reviewed and tested.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/1686#issuecomment-422233025
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20180917/63a1d8ef/attachment.html>