[bisq-network/bisq] Java 10 support (#1660)

Manfred Karrer notifications at github.com
Tue Sep 18 17:31:29 UTC 2018


ManfredKarrer requested changes on this pull request.



>      public void updateWithCurrencies(List<TradeCurrency> currencies, @Nullable CurrencyListItem first) {
         List<CurrencyListItem> result = Lists.newLinkedList();
         Optional.ofNullable(first).ifPresent(result::add);
         result.addAll(getPartitionedSortedItems(currencies));
-        setAll(result);
+        delegate.addAll(result);

To have the same behaviour as before (setAll) we should add a clear() before the addAll.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/1660#pullrequestreview-156475394
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20180918/ae740c41/attachment.html>


More information about the bisq-github mailing list