[bisq-network/bisq] Java 10 support (#1660)
Christoph Atteneder
notifications at github.com
Tue Sep 18 18:56:07 UTC 2018
@ManfredKarrer I applied your suggestions, but I have a question regarding the Status Indicator. Actually besides extending a different base class the only thing I need to change was in the constructor to replace
```
if (spinner != null) {
if (!(getSkinnable().impl_isTreeVisible() && getSkinnable().getScene() != null)) {
getChildren().remove(spinner);
spinner = null;
timeLineNulled = true;
}
}
```
with
```
if (spinner != null) {
if (getSkinnable().getScene() != null) {
getChildren().remove(spinner);
spinner = null;
timeLineNulled = true;
}
}
```
as `getSkinnable().impl_isTreeVisible()` isn't accessible anymore. Do you remember if that was the root cause of the performance issue? So I know where to look for a workaround for this missing check.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/1660#issuecomment-422507593
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20180918/1669f762/attachment-0001.html>
More information about the bisq-github
mailing list