[bisq-network/bisq] Refactoring of Btc package (#1719)

Mon Sep 24 17:17:55 UTC 2018

This PR was part of the fix of the duplicated btc nodes. While investigating I saw that the btc package was very unclearly organized. i tried to rearrange and rename classes so it provides a better structure.

It is all pure technical refactoring except https://github.com/ManfredKarrer/bisq/commit/c4d45ceecab6b8add9ff84114cc64d06ed3b8fac where we removed LTC support for seed nodes.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/1719

-- Commit Summary --

  * Move btc setup classes to setup package
  * Add missing import
  * Move exception classes to exception package
  * Further refactorings move classes to other packages
  * Further refactorings: move classes to other packages
  * Add model package and move classes
  * Fix package structure in tests
  * Rename WalletSetupPreferences to BtcNodesSetupPreferences
  * Rename WalletNetworkConfig to BtcNetworkConfig
  * Rename PeerAddressesRepository to BtcNodesRepository
  * Rename BitcoinNodes to BtcNodes
  * Rename network package to nodes
  * Add comment
  * Move classes
  * Add package info and comment
  * Remove AbstractLitecoinParams
  * Merge branch 'master' into fix-multiple-btc-peers

-- File Changes --

    M core/src/main/java/bisq/core/app/BisqExecutable.java (4)
    M core/src/main/java/bisq/core/app/BisqFacade.java (2)
    M core/src/main/java/bisq/core/app/BisqSetup.java (8)
    M core/src/main/java/bisq/core/app/WalletAppSetup.java (2)
    M core/src/main/java/bisq/core/app/misc/ExecutableForAppWithP2p.java (2)
    M core/src/main/java/bisq/core/arbitration/DisputeManager.java (4)
    M core/src/main/java/bisq/core/btc/BitcoinModule.java (8)
    A core/src/main/java/bisq/core/btc/blockchain/package-info.java (20)
    R core/src/main/java/bisq/core/btc/exceptions/AddressEntryException.java (2)
    R core/src/main/java/bisq/core/btc/exceptions/InsufficientBsqException.java (2)
    R core/src/main/java/bisq/core/btc/exceptions/InsufficientFundsException.java (2)
    R core/src/main/java/bisq/core/btc/exceptions/TxBroadcastException.java (2)
    R core/src/main/java/bisq/core/btc/exceptions/TxBroadcastTimeoutException.java (9)
    R core/src/main/java/bisq/core/btc/exceptions/TxMalleabilityException.java (2)
    R core/src/main/java/bisq/core/btc/listeners/BsqBalanceListener.java (2)
    R core/src/main/java/bisq/core/btc/model/AddressEntry.java (2)
    R core/src/main/java/bisq/core/btc/model/AddressEntryList.java (2)
    R core/src/main/java/bisq/core/btc/model/BalanceModel.java (2)
    R core/src/main/java/bisq/core/btc/model/InputsAndChangeOutput.java (2)
    R core/src/main/java/bisq/core/btc/model/PreparedDepositTxAndMakerInputs.java (2)
    R core/src/main/java/bisq/core/btc/model/RawTransactionInput.java (2)
    R core/src/main/java/bisq/core/btc/nodes/BtcNetworkConfig.java (14)
    R core/src/main/java/bisq/core/btc/nodes/BtcNodeConverter.java (4)
    R core/src/main/java/bisq/core/btc/nodes/BtcNodes.java (8)
    R core/src/main/java/bisq/core/btc/nodes/BtcNodesRepository.java (30)
    R core/src/main/java/bisq/core/btc/nodes/BtcNodesSetupPreferences.java (35)
    R core/src/main/java/bisq/core/btc/nodes/ProxySocketFactory.java (2)
    R core/src/main/java/bisq/core/btc/nodes/SeedPeersSocks5Dns.java (4)
    R core/src/main/java/bisq/core/btc/setup/BisqDeterministicKeyChain.java (2)
    R core/src/main/java/bisq/core/btc/setup/BisqKeyChainFactory.java (2)
    R core/src/main/java/bisq/core/btc/setup/BisqKeyChainGroup.java (2)
    R core/src/main/java/bisq/core/btc/setup/BsqWallet.java (2)
    R core/src/main/java/bisq/core/btc/setup/BtcDeterministicKeyChain.java (2)
    R core/src/main/java/bisq/core/btc/setup/RegTestHost.java (2)
    R core/src/main/java/bisq/core/btc/setup/WalletConfig.java (5)
    R core/src/main/java/bisq/core/btc/setup/WalletsSetup.java (38)
    M core/src/main/java/bisq/core/btc/wallet/BisqDefaultCoinSelector.java (2)
    D core/src/main/java/bisq/core/btc/wallet/BsqUtxoTransactionOutput.java (74)
    M core/src/main/java/bisq/core/btc/wallet/BsqWalletService.java (4)
    M core/src/main/java/bisq/core/btc/wallet/BtcWalletService.java (10)
    R core/src/main/java/bisq/core/btc/wallet/Restrictions.java (2)
    M core/src/main/java/bisq/core/btc/wallet/TradeWalletService.java (10)
    M core/src/main/java/bisq/core/btc/wallet/TxBroadcaster.java (4)
    M core/src/main/java/bisq/core/btc/wallet/WalletService.java (1)
    M core/src/main/java/bisq/core/btc/wallet/WalletsManager.java (1)
    M core/src/main/java/bisq/core/dao/bonding/lockup/LockupService.java (4)
    M core/src/main/java/bisq/core/dao/bonding/unlock/UnlockService.java (4)
    M core/src/main/java/bisq/core/dao/governance/blindvote/MyBlindVoteListService.java (4)
    M core/src/main/java/bisq/core/dao/governance/proposal/MyProposalListService.java (4)
    M core/src/main/java/bisq/core/dao/governance/votereveal/VoteRevealService.java (4)
    M core/src/main/java/bisq/core/filter/FilterManager.java (6)
    M core/src/main/java/bisq/core/offer/OfferUtil.java (2)
    M core/src/main/java/bisq/core/offer/placeoffer/tasks/CreateMakerFeeTx.java (4)
    M core/src/main/java/bisq/core/payment/validation/AltCoinAddressValidator.java (12)
    M core/src/main/java/bisq/core/presentation/BalancePresentation.java (2)
    M core/src/main/java/bisq/core/proto/ProtoDevUtil.java (2)
    M core/src/main/java/bisq/core/proto/persistable/CorePersistenceProtoResolver.java (2)
    M core/src/main/java/bisq/core/setup/CorePersistedDataHost.java (2)
    M core/src/main/java/bisq/core/trade/TradeManager.java (4)
    M core/src/main/java/bisq/core/trade/messages/PayDepositRequest.java (2)
    M core/src/main/java/bisq/core/trade/messages/PublishDepositTxRequest.java (2)
    M core/src/main/java/bisq/core/trade/protocol/ProcessModel.java (2)
    M core/src/main/java/bisq/core/trade/protocol/TradingPeer.java (2)
    M core/src/main/java/bisq/core/trade/protocol/tasks/buyer/BuyerProcessPayoutTxPublishedMessage.java (2)
    M core/src/main/java/bisq/core/trade/protocol/tasks/buyer/BuyerSendCounterCurrencyTransferStartedMessage.java (2)
    M core/src/main/java/bisq/core/trade/protocol/tasks/buyer/BuyerSetupPayoutTxListener.java (2)
    M core/src/main/java/bisq/core/trade/protocol/tasks/buyer_as_maker/BuyerAsMakerCreatesAndSignsDepositTx.java (6)
    M core/src/main/java/bisq/core/trade/protocol/tasks/buyer_as_maker/BuyerAsMakerSignPayoutTx.java (2)
    M core/src/main/java/bisq/core/trade/protocol/tasks/buyer_as_taker/BuyerAsTakerCreatesDepositTxInputs.java (4)
    M core/src/main/java/bisq/core/trade/protocol/tasks/buyer_as_taker/BuyerAsTakerSignAndPublishDepositTx.java (6)
    M core/src/main/java/bisq/core/trade/protocol/tasks/maker/MakerCreateAndSignContract.java (2)
    M core/src/main/java/bisq/core/trade/protocol/tasks/maker/MakerProcessDepositTxPublishedMessage.java (2)
    M core/src/main/java/bisq/core/trade/protocol/tasks/maker/MakerSendPublishDepositTxRequest.java (2)
    M core/src/main/java/bisq/core/trade/protocol/tasks/maker/MakerSetupDepositTxListener.java (2)
    M core/src/main/java/bisq/core/trade/protocol/tasks/seller/SellerBroadcastPayoutTx.java (2)
    M core/src/main/java/bisq/core/trade/protocol/tasks/seller/SellerSignAndFinalizePayoutTx.java (2)
    M core/src/main/java/bisq/core/trade/protocol/tasks/seller_as_maker/SellerAsMakerCreatesAndSignsDepositTx.java (6)
    M core/src/main/java/bisq/core/trade/protocol/tasks/seller_as_taker/SellerAsTakerCreatesDepositTxInputs.java (4)
    M core/src/main/java/bisq/core/trade/protocol/tasks/seller_as_taker/SellerAsTakerSignAndPublishDepositTx.java (6)
    M core/src/main/java/bisq/core/trade/protocol/tasks/taker/CreateTakerFeeTx.java (4)
    M core/src/main/java/bisq/core/trade/protocol/tasks/taker/TakerSendPayDepositRequest.java (2)
    M core/src/main/java/bisq/core/trade/protocol/tasks/taker/TakerVerifyAndSignContract.java (2)
    M core/src/main/java/bisq/core/user/Preferences.java (6)
    M core/src/main/java/bisq/core/user/PreferencesPayload.java (2)
    R core/src/test/java/bisq/core/btc/nodes/BtcNetworkConfigTest.java (12)
    R core/src/test/java/bisq/core/btc/nodes/BtcNodeConverterTest.java (6)
    R core/src/test/java/bisq/core/btc/nodes/BtcNodesRepositoryTest.java (14)
    R core/src/test/java/bisq/core/btc/nodes/BtcNodesSetupPreferencesTest.java (19)
    R core/src/test/java/bisq/core/btc/wallet/RestrictionsTest.java (2)
    M core/src/test/java/bisq/core/payment/validation/AltCoinAddressValidatorTest.java (6)
    M desktop/src/main/java/bisq/desktop/main/MainViewModel.java (2)
    M desktop/src/main/java/bisq/desktop/main/account/arbitratorregistration/ArbitratorRegistrationViewModel.java (2)
    M desktop/src/main/java/bisq/desktop/main/dao/bonding/BondingViewUtils.java (2)
    M desktop/src/main/java/bisq/desktop/main/dao/bonding/lockup/LockupView.java (4)
    M desktop/src/main/java/bisq/desktop/main/dao/bonding/unlock/UnlockView.java (2)
    M desktop/src/main/java/bisq/desktop/main/dao/governance/make/MakeProposalView.java (4)
    M desktop/src/main/java/bisq/desktop/main/dao/governance/proposals/ProposalsView.java (2)
    M desktop/src/main/java/bisq/desktop/main/dao/wallet/BsqBalanceUtil.java (2)
    M desktop/src/main/java/bisq/desktop/main/dao/wallet/send/BsqSendView.java (10)
    M desktop/src/main/java/bisq/desktop/main/dao/wallet/tx/BsqTxView.java (2)
    M desktop/src/main/java/bisq/desktop/main/funds/deposit/DepositListItem.java (2)
    M desktop/src/main/java/bisq/desktop/main/funds/deposit/DepositView.java (2)
    M desktop/src/main/java/bisq/desktop/main/funds/locked/LockedListItem.java (2)
    M desktop/src/main/java/bisq/desktop/main/funds/locked/LockedView.java (2)
    M desktop/src/main/java/bisq/desktop/main/funds/reserved/ReservedListItem.java (2)
    M desktop/src/main/java/bisq/desktop/main/funds/reserved/ReservedView.java (2)
    M desktop/src/main/java/bisq/desktop/main/funds/transactions/TransactionsView.java (2)
    M desktop/src/main/java/bisq/desktop/main/funds/withdrawal/WithdrawalListItem.java (2)
    M desktop/src/main/java/bisq/desktop/main/funds/withdrawal/WithdrawalView.java (10)
    M desktop/src/main/java/bisq/desktop/main/offer/MutableOfferDataModel.java (6)
    M desktop/src/main/java/bisq/desktop/main/offer/MutableOfferViewModel.java (4)
    M desktop/src/main/java/bisq/desktop/main/offer/OfferDataModel.java (2)
    M desktop/src/main/java/bisq/desktop/main/offer/createoffer/CreateOfferViewModel.java (2)
    M desktop/src/main/java/bisq/desktop/main/offer/takeoffer/TakeOfferDataModel.java (4)
    M desktop/src/main/java/bisq/desktop/main/offer/takeoffer/TakeOfferViewModel.java (2)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/DisputeSummaryWindow.java (2)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/EmptyWalletWindow.java (4)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/ManualPayoutTxWindow.java (4)
    M desktop/src/main/java/bisq/desktop/main/portfolio/editoffer/EditOfferViewModel.java (2)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesDataModel.java (2)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/buyer/BuyerStep4View.java (8)
    M desktop/src/main/java/bisq/desktop/main/settings/network/NetworkSettingsView.java (44)
    M desktop/src/main/java/bisq/desktop/util/GUIUtil.java (2)
    M desktop/src/main/java/bisq/desktop/util/validation/BsqValidator.java (2)
    M desktop/src/main/java/bisq/desktop/util/validation/BtcValidator.java (2)
    M desktop/src/main/java/bisq/desktop/util/validation/SecurityDepositValidator.java (2)
    M desktop/src/test/java/bisq/desktop/main/offer/createoffer/CreateOfferViewModelTest.java (2)
    M monitor/src/main/java/bisq/monitor/MonitorAppSetup.java (2)
    M monitor/src/main/java/bisq/monitor/metrics/MetricsModel.java (26)
    M p2p/src/main/java/bisq/network/Socks5SeedOnionDiscovery.java (8)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/1719.patch
https://github.com/bisq-network/bisq/pull/1719.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/1719
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20180924/e30057b0/attachment-0001.html>