[bisq-network/bisq] Add missing check for mandatory bsq output (#2614)
Christoph Atteneder
notifications at github.com
Tue Apr 2 07:27:26 UTC 2019
ripcurlx commented on this pull request.
> @@ -550,10 +554,19 @@ private void addInputsAndChangeOutputForTx(Transaction tx, Coin fee, BsqCoinSele
try {
// TODO why is fee passed to getChange ???
Coin change = bsqCoinSelector.getChange(fee, coinSelection);
+ if (requireChangeOutput) {
+ checkArgument(change.isPositive(),
+ "This transaction requires a mandatory BSQ change output. " +
+ "You are missing " + Restrictions.getMinNonDustOutput().value / 100d +
+ " BSQ for a non dust change output.");
Thanks for verifying the issue. Just wanted to do it myself as well, before the merge :-)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2614#discussion_r271163749
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190402/c09395d0/attachment-0001.html>
More information about the bisq-github
mailing list