[bisq-network/bisq] Add missing check for mandatory bsq output (#2614)

Manfred Karrer notifications at github.com
Wed Apr 3 00:28:24 UTC 2019

ManfredKarrer commented on this pull request.

> @@ -330,8 +330,10 @@ static boolean isTxInvalid(TempTx tempTx, boolean bsqOutputFound, boolean burntB
             return true;
-        if (!bsqOutputFound) {
-            log.warn("Invalid Tx: No BSQ output found. tx=" + tempTx);
+        if ((tempTx.getTxType() == TxType.COMPENSATION_REQUEST ||
+                tempTx.getTxType() == TxType.REIMBURSEMENT_REQUEST)
+                && !bsqOutputFound) {

Yes it was needed as otherwise we would enfore a mandatory BSQ change for all BSQ txs. For the comp request we need it to make parsing easier with the BTC candidate output but for others not.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190402/93a338d9/attachment.html>

More information about the bisq-github mailing list