[bisq-network/bisq] Check if selected proposal is null (#2636)

Christoph Atteneder notifications at github.com
Thu Apr 4 14:47:45 UTC 2019


> utACK
> 
> Should be tested good. Not 100% sure if the handling of the selction/hide is covering all situations correctly from the timing behaviour...

For that I was using the onHidden trigger. Worked for me now during testing except after having a proposal window open until the next cycle starts because of the current logic (doesn't break anything if it is closed).  If we want to be on the 100% safe side, we could just hide the window after a new block was parsed.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2636#issuecomment-479928386
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190404/cdeda6e5/attachment-0001.html>


More information about the bisq-github mailing list