[bisq-network/bisq] Improve tx display for BTC withdrawal from BSQ wallet (#2655)
Manfred Karrer
notifications at github.com
Fri Apr 5 15:25:31 UTC 2019
ManfredKarrer approved this pull request.
See comment for small improvemet and double check dust limit, beside that utACK
> @@ -296,18 +296,25 @@ private void addSendBtcGroup() {
Transaction txWithBtcFee = btcWalletService.completePreparedSendBsqTx(preparedSendTx, true);
Transaction signedTx = bsqWalletService.signTx(txWithBtcFee);
Coin miningFee = signedTx.getFee();
- int txSize = signedTx.bitcoinSerialize().length;
- showPublishTxPopup(receiverAmount,
- txWithBtcFee,
- TxType.INVALID,
- miningFee,
- txSize, receiversBtcAddressInputTextField.getText(),
- btcFormatter,
- btcFormatter,
- () -> {
- receiversBtcAddressInputTextField.setText("");
- btcAmountInputTextField.setText("");
- });
+
+ if (miningFee.getValue() > receiverAmount.getValue())
I think a check that the output is no below dust limit is in the wallet service, but maybe better to cross check?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2655#pullrequestreview-223338399
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190405/1c762296/attachment.html>
More information about the bisq-github
mailing list