[bisq-network/bisq] Improve tx display for BTC withdrawal from BSQ wallet (#2655)

Christoph Atteneder notifications at github.com
Fri Apr 5 15:33:35 UTC 2019


ripcurlx commented on this pull request.



> @@ -296,18 +296,25 @@ private void addSendBtcGroup() {
                     Transaction txWithBtcFee = btcWalletService.completePreparedSendBsqTx(preparedSendTx, true);
                     Transaction signedTx = bsqWalletService.signTx(txWithBtcFee);
                     Coin miningFee = signedTx.getFee();
-                    int txSize = signedTx.bitcoinSerialize().length;
-                    showPublishTxPopup(receiverAmount,
-                            txWithBtcFee,
-                            TxType.INVALID,
-                            miningFee,
-                            txSize, receiversBtcAddressInputTextField.getText(),
-                            btcFormatter,
-                            btcFormatter,
-                            () -> {
-                                receiversBtcAddressInputTextField.setText("");
-                                btcAmountInputTextField.setText("");
-                            });
+
+                    if (miningFee.getValue() > receiverAmount.getValue())

Yes, we probably should already prevent it, if the amount will be ```0``` in the end. Maybe we should also prevent it already before, but there it is hard where to draw a line.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2655#discussion_r272640142
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190405/4cdfcd96/attachment.html>


More information about the bisq-github mailing list