[bisq-network/bisq] Reduce tx broadcast timeout (#2657)
notifications at github.com
Fri Apr 5 20:14:06 UTC 2019
This follows after a discussion with @oscarguindzberg about his finding of the tx broadcast bug.
It will require more time to get the proper bugfix for the underlying problem (tx confidence handling in btcj). The issues only happens at BSQ txs as there the complete methods is called before the final tx is created. We discussed different intermediate fixes but decided to not add any risk and just reduce the timeout so that it does not cause issues on the trade protocol as well to not force a too long delay at proposal or blind vote publishings.
This happen only if you are connected to more then 1 btc peer) not on local regtest or dao_regtest....
The tx broadcast itself has no bug, it is just that we don't hear back because the confidence object has changed and the success handler depends on that. So changing to a rather short time of 5 seconds is justified. The trade protocol has 1 minute timeout and to lose in the trade fee tx publishing too much time on that would risk that the trade protocol cause an timeout error. This would be only the case when BSQ is used as trade fee.
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the bisq-github