[bisq-network/bisq] Handle #2659, no output for asset fee tx (#2664)
Manfred Karrer
notifications at github.com
Sun Apr 7 03:12:30 UTC 2019
ManfredKarrer commented on this pull request.
> @@ -150,7 +150,7 @@ String getWalletAsString(boolean includePrivKeys) {
public Transaction completePreparedBurnBsqTx(Transaction preparedBurnFeeTx, byte[] opReturnData)
throws WalletException, InsufficientMoneyException, TransactionVerificationException {
- return completePreparedProposalTx(preparedBurnFeeTx, opReturnData, null, null);
+ return completePreparedBsqTx(preparedBurnFeeTx, false, opReturnData);
That method is also called from BaseProposalFactory for proposals.
I need more time to check if completePreparedBurnBsqTx could be used for proposals.
> @@ -150,7 +150,7 @@ String getWalletAsString(boolean includePrivKeys) {
public Transaction completePreparedBurnBsqTx(Transaction preparedBurnFeeTx, byte[] opReturnData)
throws WalletException, InsufficientMoneyException, TransactionVerificationException {
- return completePreparedProposalTx(preparedBurnFeeTx, opReturnData, null, null);
+ return completePreparedBsqTx(preparedBurnFeeTx, false, opReturnData);
Not sure if that fix is worth the effort and risk atm, it is a very unlikely event that the input matches exactly the miner fee. And I assume it would fail anyway on the BitcoinJ side at least for the case with no outputs. Maybe we postpone that for a later time as it is not relevant for consensus anyway?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2664#pullrequestreview-223563587
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190406/98c9c432/attachment.html>
More information about the bisq-github
mailing list